BleepingComputer.com: C++ Guessing game

//============================================================================


#include <iostream>
using namespace std;

bool numberGuessed = false;

int guessRun(int user, int computer, bool numberGuessed){
	
		if (user > computer){
			cout << "Number too large!\n";
		}
		else if (user < computer){
			cout << "Number too small!\n";
		}
		else if (user == computer){
			cout << "You Have Entered The Correct Value\n";
			numberGuessed = true;
			
		
	}
	return 0;
}

int main() {
	int chosenNumber = 22;
	int userNumber;
	int userIncrement;
	
	while (numberGuessed == false ){
		cout << "Guess The Number: \n";
		cout << "Please Enter A Number That You Think Is Valid \n";
		cin >> userNumber;
		cout << numberGuessed+"\n";
		guessRun(userNumber, chosenNumber, numberGuessed);
		userIncrement++;
		}
	return 0;
}

Can anyone help me him work out why the boolean numberGuessed isn't changed when the user guesses the right number? I at least think this is the program, because if the bool is set to true at the beginning, then the program never executes. However, when the user has guessed the right number, the bool isn't assigned true and the program always contines.

Any help would be appreciated.

Thanks!

Hello, danbrownlow

You are passing the boolean value by value, while you need to pass it by reference. Pass a pointer to the function so that it may modify the item you want, rather than the value of the item you want.
Syntax is here:
http://publib.boulder.ibm.com/infocenter/c...ref/cplr233.htm

Hope that helps,

Billy3

What is the difference in passing a reference and passing a pointer and passing by reference?

Romeo29, on Oct 10 2008, 03:52 AM, said:

I'm not sure I quite understand what you mean but I will explain the difference between passing by value and passing by reference.

When you pass variables to functions by value, they are copied onto the stack, so that the function may access them. This means that in the above code:

Quote

A copy of numberGuessed is pushed onto the stack. The function may modify this copy, but the original stays the same. Hence, numberGuessed is always false.

When you pass by reference:

Quote

You are passing the address of the original. This means that you can access the original by using that address:

Quote

And this will actually modify the original, causing the effect that you want.

Hope this helps, any more questions just ask.

Thanks for your explanation ipshortdtuff.

No probs

It's been a while since I've used c++, but I noticed your function returns 0. If memory serves, 0 = false, meaning your function will always return false causing your program to continue even though the correct number was guessed. Have your function return the variable numberguessed instead.

On a side note, you are incrementing the variable userIncrement, but have not given it an initial value, nor are you using this variable for anything. Unless you are counting the number of guesses the user makes, you may want to drop this variable.

This post has been edited by strangerdanger: 12 October 2008 - 10:20 PM

StrangerDanger, he's not using the return value of the funcion, he's trying to pass values back and forth via arguments.

But the uninitialized variables do present a problem ;)

Billy3