C++ register string value error, Wrong data value Options

[KaZu]

Hello all, I got some problem with these functions: RegCreateKey, RegSetValueEx,RegQueryValueEx,RegOpenKeyEx and I dont need a URL to msdn. The problem is that its working 2/3 :-).
Output in the register should be like this:
Name: Test
Type: REG_SZ
Data: C:\WINDOWS\system32\test.exe

But I get this:
Name: Test
Type: REG_SZ
Data: [][][][][][][][][][][][][][]

My code is below, do anyone see the problem?
hope you dont mind to help me :-).
//KaZu



#include <windows.h>
#include <stdio.h>
#include <winuser.h>

#define BUFSIZE 120
int test_key(void);
int create_key(char *);
int main(void)
{
char *path = new char[40];
path ="C:\\WINDOWS\\system32\\test.exe";

int test,create; // just holders to get the return value from functions

test=test_key(); /*check if key is available for opening*/

if (test==2)/*create key*/
{
//*the path in which the file needs to be*/
create=create_key(path);
}


int test_key(void) // function to check if we could open the register and check the value for specified name
{
int check;
HKEY hKey;
char path[BUFSIZE];
DWORD buf_length=BUFSIZE;
int reg_key;

reg_key=RegOpenKeyEx(HKEY_LOCAL_MACHINE,TEX("SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Run"),0,KEY_QUERY_VALUE,&hKey); // Open register
if(reg_key!=ERROR_SUCCESS)// If the value isnt ERROR_SUCCESS it have failed and returns a error, set the check = 1
{
check=1;
return check;
}

reg_key=RegQueryValueEx(hKey,TEXT("test"),NULL,NULL,(LPBYTE)path,&buf_length); // Get value for"test"

if((reg_key!=0)||(buf_length>BUFSIZE))
check=2;

if(reg_key==0)
check=0;

RegCloseKey(hKey); // Just close the key
return check;
}


int create_key(char *path)
{
int reg_key,check;
HKEY hkey;

reg_key=RegCreateKey(HKEY_LOCAL_MACHINE,TEXT("SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Run"),&hkey); // Create a key
if(reg_key==0)
{
RegSetValueEx((HKEY)hkey,TEXT("test"),0,REG_SZ,((LPBYTE)path),(sizeof(path))+1); // Set the value
check=0;
return check;
}
if(reg_key!=0)
check=1;

RegCloseKey(hkey); // close the key
return check;
}

This post has been edited by KaZu: May 11 2009, 03:48 AM

[Billy O'Neal]

You're mixing ANSI and Unicode. Use wchar_t for your character arrays.

Billy3

[KaZu]

int create_key(wchar_t *);

wchar_t *path = new wchar_t[40];
path ="C:\\WINDOWS\\system32\\test.exe"; <-- some error here now

int create_key(wchar_t *path)

whats the problem?

[groovicus]

whats the problem?

How are we supposed to know? We're not the ones sitting in front of your keyboard and monitor. A monitor, I might add, that maybe has an error message on it?

[KaZu]

Im sorry for the bad information, It was just a question to Billy, but I fixed some of that now I changed it to:

wchar_t *path = new wchar_t[40];
path = L"C:\\WINDOWS\\system32\\test.exe";

Now the value in data is "C:" of some reason, I want the whole path :S

[KaZu]

Here is the new code if it helps and you get any ideas.

#include <windows.h>
#include <stdio.h>
#include <winuser.h>


#define BUFSIZE 120
int test_key(void);
int create_key(wchar_t *);
int main(void)
{

wchar_t *path = new wchar_t[40];
path = L"C:\\WINDOWS\\system32\\test.exe";




int test,create;
test=test_key();/*check if key is available for opening*/

if (test==2)/*create key*/
{
//*the path in which the file needs to be*/
create=create_key(path);
}
}

int test_key(void)
{
int check;
HKEY hKey;
//char path[BUFSIZE];
wchar_t path[BUFSIZE];
DWORD buf_length=BUFSIZE;
int reg_key;

reg_key=RegOpenKeyEx(HKEY_LOCAL_MACHINE,TEXT("SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Run"),0,KEY_QUERY_VALUE,&hKey);
if(reg_key!=ERROR_SUCCESS)
{
check=1;
return check;
}

reg_key=RegQueryValueEx(hKey,TEXT("test"),NULL,NULL,(LPBYTE)path,&buf_length);

if((reg_key!=0)||(buf_length>BUFSIZE))
check=2;
if(reg_key==0)
check=0;

RegCloseKey(hKey);
return check;
}

int create_key(wchar_t *path)
{
int reg_key,check;

HKEY hkey;

reg_key=RegCreateKey(HKEY_LOCAL_MACHINE,TEXT("SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Run"),&hkey);
if(reg_key==0)
{
RegSetValueEx((HKEY)hkey,TEXT("test"),0,REG_SZ,((LPBYTE)path),(sizeof(path))+1);
check=0;
return check;
}
if(reg_key!=0)
check=1;

RegCloseKey(hkey);
return check;
}

[Billy O'Neal]

Here is the new code if it helps and you get any ideas.

#include <windows.h>
#include <stdio.h>
#include <winuser.h>


#define BUFSIZE 120
int test_key(void);
int create_key(wchar_t *);
int main(void)
{

wchar_t *path = new wchar_t[40];
path = L"C:\\WINDOWS\\system32\\test.exe";




int test,create;
test=test_key();/*check if key is available for opening*/

if (test==2)/*create key*/
{
//*the path in which the file needs to be*/
create=create_key(path);
}
}

int test_key(void)
{
int check;
HKEY hKey;
//char path[BUFSIZE];
wchar_t path[BUFSIZE];
DWORD buf_length=BUFSIZE;
int reg_key;

reg_key=RegOpenKeyEx(HKEY_LOCAL_MACHINE,TEXT("SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Run"),0,KEY_QUERY_VALUE,&hKey);
if(reg_key!=ERROR_SUCCESS)
{
check=1;
return check;
}

reg_key=RegQueryValueEx(hKey,TEXT("test"),NULL,NULL,(LPBYTE)path,&buf_length);

if((reg_key!=0)||(buf_length>BUFSIZE))
check=2;
if(reg_key==0)
check=0;

RegCloseKey(hKey);
return check;
}

int create_key(wchar_t *path)
{
int reg_key,check;

HKEY hkey;

reg_key=RegCreateKey(HKEY_LOCAL_MACHINE,TEXT("SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Run"),&hkey);
if(reg_key==0)
{
RegSetValueEx((HKEY)hkey,TEXT("test"),0,REG_SZ,((LPBYTE)path),(sizeof(path))+1);
check=0;
return check;
}
if(reg_key!=0)
check=1;

RegCloseKey(hkey);
return check;
}

What is sizeof(path) ? It sure isn't the length of the array.....

Billy3

[Billy O'Neal]

wchar_t *path = new wchar_t[40];
path = L"C:\\WINDOWS\\system32\\test.exe";

This code is invalid and causes a memory leak.

Needs to be replaced with:
wchar_t *path = L"C:\\WINDOWS\\system32\\test.exe";

[KaZu]

I fixed the L problem, the sizeof should take out this parameter of the function: RegSetValueEx

last paramter:

cbData [in]

The size of the information pointed to by the lpData parameter, in bytes. If the data is of type REG_SZ, REG_EXPAND_SZ, or REG_MULTI_SZ, cbData must include the size of the terminating null character or characters.

[Billy O'Neal]

What is sizeof(path) ? Remember, arrays in C(++) are merely pointers to their first element. Sizeof() does NOT return the length of the array for string. It returns the size of the pointer type, which on 32 bit architectures is 4. This is why you are getting 2 characters of output.. each wchar_t character is two bytes wide, and RegSetValueEx is assuming the string is 4 bytes long. To get the length of the string, you need to use wcslen(), and you need to multiply it by the size of a wchar_t in order to get things in bytes.

Therefore:
wcslen(path)*sizeof(wchar_t)
is the value you are looking for, not sizeof(path)

C arrays have no direct way of accessing an array's length. wcslen() simply searches for the NULL at the end of the NULL terminated string.

Billy3

[KaZu]

Thanks alot for the info and now my program is working. And again, thanks billy3

[Billy O'Neal]

No problem

However... I have a question for you.....

Can you tell me what the problem with this code is?

wchar_t *path = new wchar_t[40];
path = L"C:\\WINDOWS\\system32\\test.exe";

Billy3

[KaZu]

Hehe I can see that it allocate memory and should be used with delete ;)

[Billy O'Neal]

Yep

What did this line do?
path = L"C:\\WINDOWS\\system32\\test.exe";

Billy3

[KaZu]

The first, I mixed up Unicode and ANSI code, had to use wchar_t for my arrays as you said.

So just to say other words. Because I have wchar_t array it´s not right to set a string value direct to it, so I use the L or TEXT macro to fix this problem(tell the compiler that the string is a wide character value. This is right? :-)